Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extrapolated prediction to drift compensation #1184

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

nekomona
Copy link
Contributor

@nekomona nekomona commented Sep 28, 2024

Previous drift compensation only interpolates between current yaw and the inverse of recorded drifts. This limits the compensation effectiveness as the drift would spin the tracker continuously, moving beyond the recorded drift angle.

This PR would keep rotating the compensation angle at the speed averaged from recorded drifts. It would give better compensation result at the presence of continuous drifting for a longer period of time.

Depending on SlimeVR/SolarXR-Protocol#148

@ButterscotchV ButterscotchV added Type: Enhancement Adds or improves a feature Area: Translation Improvements or additions to translations Area: Server Related to the server Area: GUI Related to the GUI labels Oct 7, 2024
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, previous implementation was kinda weird so this is much cleaner

@loucass003 loucass003 merged commit 1a88eba into SlimeVR:main Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Area: Server Related to the server Area: Translation Improvements or additions to translations Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants