Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on OBTAINING_MAC_ADDRESS #1206

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Fix typo on OBTAINING_MAC_ADDRESS #1206

merged 5 commits into from
Oct 25, 2024

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Oct 21, 2024 •
edited
Loading

ButterscotchV
ButterscotchV approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the WiFi onboarding might also be broken in general because of the MAC step?

@ImUrX
Copy link
Member Author

ImUrX commented Oct 21, 2024

yeah, i fixed that in the solarxr side, it was because the step was added in the middle of the enum instead of appended

@ImUrX ImUrX added Type: Bug Something isn't working Area: Application Protocol Related to communication with apps like the GUI, overlay, games labels Oct 24, 2024
@ButterscotchV ButterscotchV mentioned this pull request Oct 25, 2024
Open
@ImUrX ImUrX merged commit 7cb500a into main Oct 25, 2024
12 checks passed
@ImUrX ImUrX deleted the optaining-typo branch October 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

Assignees
No one assigned
Labels
Area: Application Protocol Related to communication with apps like the GUI, overlay, games Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImUrX @ButterscotchV @Erimelowo