Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page not opening #359

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Fix page not opening #359

merged 2 commits into from
Dec 13, 2022

Conversation

macluxHD
Copy link
Contributor

The page opens now when pressing "I'm having trouble connecting!" Button, even if typedState is undefiend.

Fixes #345

loucass003
loucass003 requested changes Dec 10, 2022
View reviewed changes
Copy link
Member

@loucass003 loucass003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not enough. We need the button in the wifi window to set the state with a port
Auto for now will be best

@macluxHD
Copy link
Contributor Author

The Button now sets the SerialPort State to Auto

@Eirenliel Eirenliel merged commit df43e5f into SlimeVR:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loucass003 loucass003 loucass003 approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

”I'm having trouble connecting!” button has trouble
3 participants
@macluxHD @Eirenliel @loucass003