Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fluent format for translations #414

Merged
merged 6 commits into from
Dec 21, 2022
Merged

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Dec 21, 2022

Some languages have to make worse translations because of the current limitation that we use JSONs, I propose using fluent will make translation a lot easier for these languages that have a limitation for such a thing.

The actual issue is that we reuse terms in different sentences and just remaking the key 60 times wont be nice for translators either. There is more info on cases like locative in here.

Namings were changed from prop.prop-name to prop-prop_name as . means an attribute in fluent

@ImUrX
Copy link
Member Author

ImUrX commented Dec 21, 2022

By the way, this PR will only include the conversion to fluent, I will add the actual fluent syntaxing in another PR

@ImUrX ImUrX marked this pull request as ready for review December 21, 2022 05:02
@ImUrX
Copy link
Member Author

ImUrX commented Dec 21, 2022

The JSONs should get removed when it's merged or right before merging so translators don't get mixed up

@ImUrX ImUrX added Area: GUI Related to the GUI Area: Translation Improvements or additions to translations labels Dec 21, 2022
@Eirenliel Eirenliel merged commit 9130b99 into SlimeVR:main Dec 21, 2022
@Eirenliel
Copy link
Member

Please work with other translators to move to the new format :firBless:

@ImUrX ImUrX deleted the fluent-translation branch January 13, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Area: Translation Improvements or additions to translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants