Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using fluent syntaxing #423

Merged
merged 25 commits into from
Jan 3, 2023
Merged

Start using fluent syntaxing #423

merged 25 commits into from
Jan 3, 2023

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Dec 23, 2022

For now I only modified parameters that used variables and added plurality and that kind of stuff

@ImUrX ImUrX force-pushed the fluent-advanced branch 2 times, most recently from 8a60105 to d8e230e Compare December 25, 2022 18:32
@ImUrX ImUrX added the Area: Translation Improvements or additions to translations label Dec 25, 2022
@ImUrX
Copy link
Member Author

ImUrX commented Dec 27, 2022

Will make some people test it now 😭

@ImUrX ImUrX marked this pull request as ready for review December 27, 2022 19:18
@ImUrX
Copy link
Member Author

ImUrX commented Dec 27, 2022

Big PR, what should be reviewed is at least one useLocalization() hook to see if it's okay how it looks, the src/i18n/config.tsx, maybe see scripts/check-missing.js (its for checking for missing keys and extra keys), and try the app in every language and see if in the inspector console there is any warning from fluent about a missing key

@ImUrX
Copy link
Member Author

ImUrX commented Dec 27, 2022

Oh and also the english fluent file :p

Eirenliel
Eirenliel approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict and rebase to main

@ImUrX
Copy link
Member Author

ImUrX commented Jan 3, 2023

Rebased

@Eirenliel
Copy link
Member

main also doesn't build, and it looks like fluent error: [vite]: Rollup failed to resolve import "@fluent/langneg" from "src/i18n/config.tsx". so manbe you can fix it in this PR, @ImUrX?

@ImUrX
Copy link
Member Author

ImUrX commented Jan 3, 2023

Yeah, the rebase added something I removed, it was weird

@Eirenliel
Copy link
Member

It was from one of the other merges...

@Eirenliel Eirenliel merged commit 3b75b51 into SlimeVR:main Jan 3, 2023
@ImUrX ImUrX deleted the fluent-advanced branch January 3, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eirenliel Eirenliel Eirenliel approved these changes

@TheDevMinerTV TheDevMinerTV Awaiting requested review from TheDevMinerTV

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

Assignees
No one assigned
Labels
Area: Translation Improvements or additions to translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImUrX @Eirenliel @TheDevMinerTV