Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton Separation Refactor #442

Merged
merged 21 commits into from
Jan 27, 2023
Merged

Skeleton Separation Refactor #442

merged 21 commits into from
Jan 27, 2023

Conversation

Erimelowo
Copy link
Member

This is a relatively big refactor of how we interact with the skeleton. The goal is to make it more like a black box.
The outside should not have direct access to the inside, thus we are now using a HumanPoseManager to get and set everything related to the skeleton (including config)

WIP, as BVH and Autobone still need to be migrated to this new system.

@ImUrX ImUrX added Difficulty: Large refactor Requires modifying large sections of the codebase Area: Skeletal Model Deals with the model of the skeleton and its pose labels Jan 2, 2023
@Erimelowo Erimelowo marked this pull request as ready for review January 17, 2023 03:42
@Erimelowo
Copy link
Member Author

This changes the path to the processor package, so CODEOWNER will need to be adjusted consequently.

@Erimelowo
Copy link
Member Author

Also, Autobone needs testing to make sure it still works the same as it’s supposed to.

@Eirenliel
Copy link
Member

image
tldr ;_;

@Erimelowo
Copy link
Member Author

sowwy 3:

@ButterscotchV
Copy link
Member

I can review some of it, but I've contributed some to it so I'm not gonna be able to review all of it properly. I'll try to do a review and state what files I contributed and am unable to review.

@Eirenliel
Copy link
Member

Please do your best @ButterscotchV. I'll try to look through it until the end of the week.

@Eirenliel
Copy link
Member

LGTM but needs third pair of eyes

@Eirenliel Eirenliel merged commit 86f7c0d into main Jan 27, 2023
@Eirenliel Eirenliel deleted the skeleton-refactor-separation branch January 27, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Skeletal Model Deals with the model of the skeleton and its pose Difficulty: Large refactor Requires modifying large sections of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants