Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reset code and make it so VRTrackers can reset #480

Merged
merged 12 commits into from
Jan 19, 2023
Merged

Improve reset code and make it so VRTrackers can reset #480

merged 12 commits into from
Jan 19, 2023

Conversation

Erimelowo
Copy link
Member

  • Improves some reset code and make sure none of the fix___ methods are modifying the tracker's rotation (which they were, and it caused trackers to jump for a frame sometimes when resetting)
  • Make it so VRTrackers (Vive trackers) can align to HMD when resetting and quick resetting. First step in supporting Vive trackers... this will already make them more usable!

@ButterscotchV ButterscotchV added Priority: Normal The default priority Type: Enhancement Adds or improves a feature labels Jan 17, 2023
Eirenliel
Eirenliel requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not improved reset code, you added unnecessary cloning everywhere...

server/src/main/java/dev/slimevr/vr/trackers/IMUTracker.java Outdated Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/IMUTracker.java Outdated Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/IMUTracker.java Outdated Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/IMUTracker.java Outdated Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/VRTracker.java Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/VRTracker.java Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/VRTracker.java Show resolved Hide resolved
@Erimelowo
Copy link
Member Author

Somehow thought inverseLocal created a new Quaternion and inverse didn’t, but it’s the opposite ;-;

Eirenliel
Eirenliel requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Eirenliel Eirenliel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for consistency.

server/src/main/java/dev/slimevr/vr/trackers/IMUTracker.java Outdated Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/trackers/IMUTracker.java Outdated Show resolved Hide resolved
Erimelowo and others added 2 commits January 18, 2023 20:32
@Erimelowo @Eirenliel
eiren suggestion 1
48d95d3 
Co-authored-by: Eiren Rain <Eirenliel@users.noreply.github.com>
@Erimelowo @Eirenliel
eiren suggestion 2
6a02344 
Co-authored-by: Eiren Rain <Eirenliel@users.noreply.github.com>
@Eirenliel Eirenliel merged commit 9415ece into main Jan 19, 2023
@Eirenliel Eirenliel deleted the vrtracker-reset branch January 19, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

Assignees
No one assigned
Labels
Priority: Normal The default priority Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erimelowo @Eirenliel @ButterscotchV