Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: add missing german translations #495

Merged
merged 12 commits into from
Jan 30, 2023
Merged

i18n: add missing german translations #495

merged 12 commits into from
Jan 30, 2023

Conversation

TheDevMinerTV
Copy link
Member

No description provided.

@ButterscotchV ButterscotchV added the Area: Translation Improvements or additions to translations label Jan 20, 2023
Erimelowo
Erimelowo requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename "SSID" to the german translation of "Wi-Fi name" please? Most people don't know what SSID means

unlogisch04
unlogisch04 requested changes Jan 20, 2023
View reviewed changes
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
@TheDevMinerTV
Copy link
Member Author

I'm still not done xd

@TheDevMinerTV
Copy link
Member Author

@TheDevMinerTV TheDevMinerTV requested a review from ImUrX as a code owner

no, github, I, in fact, did not do this.

@ImUrX
Copy link
Member

ImUrX commented Jan 28, 2023

How could GitHub lie to me

unlogisch04
unlogisch04 requested changes Jan 28, 2023
View reviewed changes
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
TheDevMinerTV and others added 2 commits January 28, 2023 21:49
@TheDevMinerTV @unlogisch04
Update gui/public/i18n/de/translation.ftl
56e93f7 
Co-authored-by: unlogisch04 <98281608+unlogisch04@users.noreply.github.com>
@unlogisch04
Update gui/public/i18n/de/translation.ftl
cd7f7a3
@unlogisch04 unlogisch04 requested review from unlogisch04 and removed request for Philip6294 January 28, 2023 21:18
Philip6294
Philip6294 suggested changes Jan 30, 2023
View reviewed changes
gui/public/i18n/de/translation.ftl Outdated Show resolved Hide resolved
@unlogisch04
Copy link
Contributor

Could you rename "SSID" to the german translation of "Wi-Fi name" please? Most people don't know what SSID means

Should be fixed

@TheDevMinerTV @Philip6294
Update gui/public/i18n/de/translation.ftl
1c14ed3 
Co-authored-by: Philip6294 <18615404+Philip6294@users.noreply.github.com>
@TheDevMinerTV
Copy link
Member Author

Please squash merge.

@Erimelowo Erimelowo merged commit eb56fb0 into main Jan 30, 2023
@Erimelowo Erimelowo deleted the fix/missing-german-translations branch January 30, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlogisch04 unlogisch04 unlogisch04 approved these changes

@Erimelowo Erimelowo Erimelowo approved these changes

@Philip6294 Philip6294 Philip6294 approved these changes

@ImUrX ImUrX ImUrX approved these changes

@carl-anders carl-anders Awaiting requested review from carl-anders

Assignees
No one assigned
Labels
Area: Translation Improvements or additions to translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TheDevMinerTV @ImUrX @unlogisch04 @carl-anders @Philip6294 @Erimelowo @ButterscotchV