Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix switching between HMD and controller arm tracking #504

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Fix switching between HMD and controller arm tracking #504

merged 8 commits into from
Feb 2, 2023

Conversation

Erimelowo
Copy link
Member

Fix switching between HMD and controller arm tracking and improve some math and clear up some code in HumanSkeleton
Also, make the arms 0.26cm+0.26cm instead of 0.25cm+0.25cm

@ImUrX ImUrX added the Area: Skeletal Model Deals with the model of the skeleton and its pose label Jan 24, 2023
ButterscotchV
ButterscotchV requested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ^w^
Look into these and I'll approve

server/src/main/java/dev/slimevr/vr/processor/skeleton/HumanSkeleton.java Outdated Show resolved Hide resolved
server/src/main/java/dev/slimevr/vr/processor/skeleton/HumanSkeleton.java Outdated Show resolved Hide resolved
@ButterscotchV ButterscotchV added Type: Bug Something isn't working Type: Enhancement Adds or improves a feature labels Jan 26, 2023
ButterscotchV
ButterscotchV approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happier with less unecessary duplication, but I still think rotBuf3 and rotBuf4 could be used in place of leftKnee and rightKnee to reduce instantiation. If Eiren thinks this is fine then I'm okay with it, but I want it to at least be made aware.

@Erimelowo
Copy link
Member Author

I'd rather not, as this is how the method is called
image

@ButterscotchV
Copy link
Member

I'd rather not, as this is how the method is called
image

Wtff... Well then that's fine lmao, not your problem

@Eirenliel Eirenliel merged commit 4ef4120 into main Feb 2, 2023
@Eirenliel Eirenliel deleted the shoulders-improv branch February 2, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

Assignees
No one assigned
Labels
Area: Skeletal Model Deals with the model of the skeleton and its pose Type: Bug Something isn't working Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erimelowo @ButterscotchV @Eirenliel @ImUrX