Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings to the tracker selection page #547

Merged
merged 8 commits into from
Feb 12, 2023
Merged

Add warnings to the tracker selection page #547

merged 8 commits into from
Feb 12, 2023

Conversation

loucass003
Copy link
Member

No description provided.

@loucass003 loucass003 added the Area: GUI Related to the GUI label Feb 4, 2023
@ImUrX
Copy link
Member

ImUrX commented Feb 4, 2023

need to review this when i have time, wait for me :P

ButterscotchV
ButterscotchV requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the spelling, also see my recommendations for the warnings.

gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
gui/src/hooks/chocker-warning.ts Outdated Show resolved Hide resolved
gui/src/components/onboarding/BodyAssignment.tsx Outdated Show resolved Hide resolved
@ImUrX ImUrX force-pushed the llelievr/tracker-assign-warning branch from 87b0364 to ad0f255 Compare February 5, 2023 02:26
ButterscotchV
ButterscotchV approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy ^w^

@ImUrX
Copy link
Member

ImUrX commented Feb 5, 2023

glad to know :3

@Erimelowo
Copy link
Member

Made some changes to the positions of the circles (lower arms and upper legs a bit higher)
image
Can I commit directly @loucass003 ? You didn't change the lower arms' positions, so I can't just suggest changes on that :p

@loucass003
Copy link
Member Author

Made some changes to the positions of the circles (lower arms and upper legs a bit higher) image Can I commit directly @loucass003 ? You didn't change the lower arms' positions, so I can't just suggest changes on that :p

yes

@ImUrX ImUrX force-pushed the llelievr/tracker-assign-warning branch from 9c3b9c7 to 9290f6f Compare February 11, 2023 22:51
@Eirenliel Eirenliel merged commit 2b7b5dc into main Feb 12, 2023
@Eirenliel Eirenliel deleted the llelievr/tracker-assign-warning branch February 12, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

@ImUrX ImUrX Awaiting requested review from ImUrX ImUrX is a code owner

Assignees
No one assigned
Labels
Area: GUI Related to the GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loucass003 @ImUrX @Erimelowo @Eirenliel @ButterscotchV