Add prettier to check formatting during CI linting #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDevMinerTV
requested review from
Erimelowo,
loucass003,
ImUrX and
Eirenliel
as code owners
Eirenliel
approved these changes
Feb 5, 2023
|
Why don’t you push the change to #553 |
ButterscotchV
approved these changes
Feb 5, 2023
ButterscotchV
added
Area: GUI
it's in your fork of the repo, not in this one |
|
you still have write perms |
|
Also, your PR title would be incorrect |
Erimelowo
reviewed
Feb 9, 2023
|
Plz fix CI, @TheDevMinerTV |
TheDevMinerTV
force-pushed
the
ci/add-prettier
branch
3 times, most recently
from
ba7202d
to
69c0df1
Compare
TheDevMinerTV
force-pushed
the
ci/add-prettier
branch
from
69c0df1
to
12fe489
Compare
loucass003
approved these changes
Feb 12, 2023
ImUrX
approved these changes
Feb 12, 2023
Quoting https://prettier.io/docs/en/integrating-with-linters.html: > The downsides of those plugins are: > You end up with a lot of red squiggly lines in your editor, which > gets annoying. Prettier is supposed to make you forget about formatting – and not be in your face about it! > They are slower than running Prettier directly. > They’re yet one layer of indirection where things may break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #553