Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lang select being too long #571

Merged
merged 6 commits into from
Feb 12, 2023
Merged

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Feb 9, 2023

Added tab support on the dropdown component and limited it to 50vh of max-height, fixed scrollbar color and added css scrollbar properties (only work with Firefox).
Also added some decorations and an alignment option on it

@ImUrX ImUrX added the Area: GUI Related to the GUI label Feb 9, 2023
Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolling has weird behaviour... It sometimes allows you to scroll (notably when the select scrollbar is at the top or bottom), and sometimes not, and it's annoying ;-;
https://cdn.discordapp.com/attachments/1044838643522601031/1073376998409383957/slimevr_GaXXkGBjxv.mp4

@ImUrX
Copy link
Member Author

ImUrX commented Feb 9, 2023

You want me to fix a browser problem 😭, I will see what I can do

@Erimelowo
Copy link
Member

Browsers suck, let's go back to TVs and phones

@ImUrX ImUrX requested a review from Erimelowo February 10, 2023 01:44
@Eirenliel Eirenliel merged commit fcb3829 into SlimeVR:main Feb 12, 2023
@ImUrX ImUrX deleted the lang-select-fix branch November 1, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants