WiFi provisioning and serial fixes #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Area: Hardware Protocol
Eirenliel
changed the title
|
this all works now btw lmao |
Erimelowo
previously requested changes
Mar 15, 2023
server/src/main/java/dev/slimevr/serial/ProvisioningHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/dev/slimevr/serial/ProvisioningHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Erimel <marioluigivideo@gmail.com>
Co-authored-by: Erimel <marioluigivideo@gmail.com>
TheDevMinerTV
force-pushed
the
provisioning-fix
branch
from
29975eb
to
2f70031
Compare
Erimelowo
reviewed
Mar 28, 2023
Erimelowo
dismissed
their stale review
dismissing since it also crashes in 0.6.3, so the crashing is unrelated to the PR
Erimelowo
approved these changes
Mar 28, 2023
ButterscotchV
requested changes
Mar 28, 2023
server/src/main/java/dev/slimevr/serial/ProvisioningHandler.java
Outdated
Show resolved
Hide resolved
| LogManager.severe("Using serial ports is not supported on this platform", e); | ||
| LogManager | ||
| .severe("[SerialHandler] Using serial ports is not supported on this platform", e); | ||
| throw new RuntimeException("Serial unsupported"); |
There was a problem hiding this comment.
Why are we getting rid of the original exception? I don't think it's even safe to do this anyways, as it crashes the server when it's unsupported. If this is being caught somewhere else, can I be pointed to it?
There was a problem hiding this comment.
It's executed in the TimerTask, I think it will just crash and stop the timer? I might be wrong, I didn't check.
There was a problem hiding this comment.
Yes, the following tasks scheduled in the timer wont run because background thread is dead
Co-authored-by: Butterscotch! <bscotchvanilla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
Some stuff is a bit broken: