-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toesnap and Footplant #609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General legtweaks review and fixes
… SlimeVR-main21
… SlimeVR-main69
update branch
Stermere
requested review from
Erimelowo,
ButterscotchV and
Eirenliel
as code owners
February 26, 2023 00:39
ButterscotchV
requested changes
Feb 26, 2023
server/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.java
Show resolved
Hide resolved
server/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.java
Outdated
Show resolved
Hide resolved
…egTweaks.java Co-authored-by: Butterscotch! <bscotchvanilla@gmail.com>
Erimelowo
requested changes
Feb 27, 2023
server/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.java
Outdated
Show resolved
Hide resolved
Erimelowo
approved these changes
Feb 27, 2023
ButterscotchV
added
Area: Skeletal Model
Deals with the model of the skeleton and its pose
Type: Enhancement
Adds or improves a feature
Area: Server
Related to the server
Area: GUI
Related to the GUI
labels
Feb 28, 2023
ButterscotchV
approved these changes
Feb 28, 2023
ButterscotchV
approved these changes
Mar 1, 2023
Eirenliel
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: GUI
Related to the GUI
Area: Server
Related to the server
Area: Skeletal Model
Deals with the model of the skeleton and its pose
Type: Enhancement
Adds or improves a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature's toe snap and foot plant, both components are focused on improving tracking without the presence of foot trackers. This addresses issue #11 and cannot be merged until SlimeVR/SolarXR-Protocol#104 is merged.