Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert AutoBone config to Kotlin and fix config loading #614

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Convert AutoBone config to Kotlin and fix config loading #614

merged 4 commits into from
Mar 2, 2023

Conversation

ButterscotchV
Copy link
Member

@ButterscotchV ButterscotchV commented Feb 28, 2023 •
edited
Loading

  • Converts AutoBone config to Kotlin to reduce the size
  • Fixes the capitalization on autobone to autoBone, since the parser seems to use the getAutoBone() method for the capitalization of the variable
  • Fixes a couple compiler warnings

@ButterscotchV ButterscotchV added Type: Bug Something isn't working Area: AutoBone The AutoBone feature Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Feb 28, 2023
@Eirenliel Eirenliel merged commit 4ff2986 into SlimeVR:main Mar 2, 2023
@ButterscotchV ButterscotchV deleted the autobone-dev-2 branch March 7, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo approved these changes

@ImUrX ImUrX ImUrX approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

@loucass003 loucass003 Awaiting requested review from loucass003

Assignees
No one assigned
Labels
Area: AutoBone The AutoBone feature Area: Server Related to the server Type: Bug Something isn't working Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ButterscotchV @Eirenliel @ImUrX @Erimelowo