Improve setup wizard #639
Improve setup wizard #639
Conversation
ImUrX
commented
Mar 23, 2023
ImUrX
commented
- Changed overlay of most buttons
- Added progress bar on provisioning for tracker
- Fixed some bugs like progress bars being remade every time and reset proportions on autobone having a countdown but no showing it
Co-authored-by: Spazznyan <98095416+Spazzwanjunk@users.noreply.github.com>
Co-authored-by: ButterscotchV <bscotchvanilla@gmail.com>
|
After #636 conflicts need to be resolved + we need to take a look at the page together and maybe do some quick changes. |
ButterscotchV
added
Type: Bug
Co-authored-by: ButterscotchV <bscotchvanilla@gmail.com>
| {l10n.getString('onboarding-setup_warning-cancel')} | ||
| </Button> | ||
| <Button | ||
| variant="tiertiary" |
There was a problem hiding this comment.
I know this is misspelled in the code for Button, but tiertiary? ;w; It should be tertiary
There was a problem hiding this comment.
this will get fixed in another PR tbh
gui/src/components/onboarding/pages/body-proportions/autobone-steps/Recording.tsx
Show resolved
Hide resolved
| const bones = []; | ||
|
|
||
| const head = new Bone(); | ||
| const neck = new Bone(); | ||
| head.add(neck); | ||
|
|
||
| const chest = new Bone(); | ||
| neck.add(chest); | ||
| const waist = new Bone(); | ||
| chest.add(waist); | ||
| const hip = new Bone(); | ||
| waist.add(hip); | ||
|
|
||
| const leftShoulder = new Bone(); | ||
| neck.add(leftShoulder); | ||
| const leftUpperArm = new Bone(); | ||
| leftShoulder.add(leftUpperArm); | ||
| const leftLowerArm = new Bone(); | ||
| leftUpperArm.add(leftLowerArm); | ||
| const leftHand = new Bone(); | ||
| leftLowerArm.add(leftHand); | ||
|
|
||
| const rightShoulder = new Bone(); | ||
| neck.add(rightShoulder); | ||
| const rightUpperArm = new Bone(); | ||
| rightShoulder.add(rightUpperArm); | ||
| const rightLowerArm = new Bone(); | ||
| rightUpperArm.add(rightLowerArm); | ||
| const rightHand = new Bone(); | ||
| rightLowerArm.add(rightHand); | ||
|
|
||
| const leftUpperLeg = new Bone(); | ||
| hip.add(leftUpperLeg); | ||
| const leftLowerLeg = new Bone(); | ||
| leftUpperLeg.add(leftLowerLeg); | ||
| const leftFoot = new Bone(); | ||
| leftLowerLeg.add(leftFoot); | ||
|
|
||
| const rightUpperLeg = new Bone(); | ||
| hip.add(rightUpperLeg); | ||
| const rightLowerLeg = new Bone(); | ||
| rightUpperLeg.add(rightLowerLeg); | ||
| const rightFoot = new Bone(); | ||
| rightLowerLeg.add(rightFoot); | ||
|
|
||
| bones.push( | ||
| head, | ||
| neck, | ||
| chest, | ||
| waist, | ||
| hip, | ||
| leftUpperLeg, | ||
| rightUpperLeg, | ||
| leftLowerLeg, | ||
| rightLowerLeg, | ||
| leftFoot, | ||
| rightFoot, | ||
| leftLowerArm, | ||
| rightLowerArm, | ||
| leftUpperArm, | ||
| rightUpperArm, | ||
| leftHand, | ||
| rightHand, | ||
| leftShoulder, | ||
| rightShoulder | ||
| ); | ||
|
|
||
| return new Skeleton(bones); | ||
| })(); |
There was a problem hiding this comment.
I'd love to have this dynamically generated in the future, why is it even hardcoded as it is now? I swear SolarXR should have enough data to generate this based off it.
There was a problem hiding this comment.
No? How can I know the hierarchy of bones dynamically?
|
I'd also like to report from some quick testing, you can still click on mounting positions even when they're invisible. As you can see in my first screenshot, I have no trackers connected. In my second screenshot, I've clicked on the invisible tracker mounting assignment position button and it shows the GUI. After clicking on one, it is no longer clickable.
|
There was a problem hiding this comment.
- In the warning popup prompting the user to do the setup when attempting to skip it, I think the "confirm" option (Skip setup) should be in purple, and the "cancel" option (Continue setup) should be in gray. It's confusing...
- Clicking "Manual calibration" in the Body proportions tab, outside of the initial setup, brings the user to the setup wizard. Same with the Mounting calibration tab.
Co-authored-by: Erimel <marioluigivideo@gmail.com>
Co-authored-by: Butterscotch! <bscotchvanilla@gmail.com>
No, because we don't want the user to skip it. It's designed by purpose. |
|
Having a confirmation popup is already doing that. |
