Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build dependencies to nix flake #929

Conversation

AnnoyingRain5
Copy link

These dependencies are required for building on nixos, they should be in the flake.

@ImUrX
Copy link
Member

ImUrX commented Jan 30, 2024

Rust is already included via fenix, is husky not included?

@AnnoyingRain5
Copy link
Author

When I ran the script on my nixOS system, I can confirm that rustc was not included by that package. I had to manually add these packages to the flake before it would compile.

@ImUrX
Copy link
Member

ImUrX commented Feb 1, 2024

That's so weird, why does it download them for me then

@AnnoyingRain5
Copy link
Author

Have you tried setting your system to sandbox mode?

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#tested-using-sandboxing

also, what system are you using nix on?

@ImUrX
Copy link
Member

ImUrX commented Feb 1, 2024

NixOS, will try it when I have time

@ImUrX
Copy link
Member

ImUrX commented Feb 1, 2024

Sandboxing is already enabled, nothing changed for me.

@ImUrX
Copy link
Member

ImUrX commented Feb 1, 2024

I guess I'm gonna go back to the classic nix develop instead of the fancy devenv, I don't really wanna debug it.

@AnnoyingRain5
Copy link
Author

If it helps, my dotfiles are at https://github.com/AnnoyingRain5/dotfiles

@ButterscotchV ButterscotchV added Type: Bug Something isn't working OS: Linux Operating system: Linux labels Feb 8, 2024
@ImUrX
Copy link
Member

ImUrX commented May 7, 2024

can you check if #1023 fixes the problem?

@ImUrX ImUrX removed the request for review from Eirenliel May 7, 2024 01:45
@AnnoyingRain5
Copy link
Author

Yep! It looks like it's fixed pending #1023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Linux Operating system: Linux Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants