-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename category -> itemGroup #3232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small mistake.
Thanks!
...va/io/github/thebusybiscuit/slimefun4/implementation/items/androids/ProgrammableAndroid.java
Outdated
Show resolved
Hide resolved
Also what about these @TheBusyBiscuit
|
Regarding the wiki reference, the wiki page itself would need to be renamed first (if thats wanted). |
I think I'm going to keep the Christmas seasonal category as-is, because I think the in-game text also still says category over itemgroup, and in this case it does make more sense Ill do the other changes in a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God GitHub hates large PRs but I couldn't find any typos or anything so looks good
Description
This is a follow up to #3139, a lot of comments and variables and error messages needed to be updated still.
This is what that does
Two more follow up questions:
wiki.json
,Christmas-Seasonal-Category
is mentioned, change toChristmas-Seasonal-ItemGroup
?messages.yml
(and other files) keys? (eg:guide.tooltips.open-category
->guide.tooltips.open-itemgroup
)Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values