Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix failure to output JSON or YAML history #492

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Mar 21, 2023

  • added missing await to getHistory call
  • updated unit tests some but then decided it would probably be worth spending more time researching switching to yargs from oclif

Checklist

  • I have read the CONTRIBUTING document
  • Any required documentation has been added
  • My code follows the code style of this project (npm run lint produces no warnings/errors)
  • I have added tests to cover my changes

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

🦋 Changeset detected

Latest commit: 6cabd52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@smartthings/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rossiam rossiam merged commit 0b7934b into SmartThingsCommunity:main Mar 21, 2023
@rossiam rossiam deleted the history-fix branch March 21, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants