Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Q&A mode to apps:aouth:generate command #502

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Apr 25, 2023

  • Added Q & A mode to apps:oauth:generate command.
  • Since this is the first "update" style Q & A command, added updateFromUserInput function to item-input/command-helpers.ts.

Checklist

  • I have read the CONTRIBUTING document
  • Any required documentation has been added
  • My code follows the code style of this project (npm run lint produces no warnings/errors)
  • I have added tests to cover my changes

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: d205e07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@smartthings/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

scope: oauthAppScopeDef,
})

return updateFromUserInput(this, inputDef, startingRequest, { dryRun: false })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user has the ability to set or not set the --dry-run flag with this command, so we should pass that instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rossiam rossiam merged commit fc9f67f into SmartThingsCommunity:main Apr 25, 2023
@rossiam rossiam deleted the qa-oauth-generate branch May 23, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants