Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 added option to read OpenSSL key, EAS base64->base64url #311

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

oleggrib
Copy link
Collaborator

Changed EAS ticket encoding to base64url, because parsers incorrectly decode ticket in base64 format

@oleggrib oleggrib requested a review from micwallace June 21, 2023 01:35
@github-actions
Copy link

Coverage report for src/main/javascript/crypto/

❌ An unexpected error occurred. For more details, check console

Error: The process '/opt/hostedtoolcache/node/16.20.0/x64/bin/npm' failed with exit code 1
St.
Category Percentage Covered / Total
🟡 Statements
76.3% (+0.05% 🔼)
2456/3219
🔴 Branches
48.94% (-0.14% 🔻)
347/709
🟢 Functions
82.35% (+0.03% 🔼)
434/527
🟡 Lines
76.51% (+0.05% 🔼)
2414/3155
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 libs/utils.ts
87.67% (-0.35% 🔻)
63.89% (-1.39% 🔻)
97.14% (+0.08% 🔼)
89% (-0.39% 🔻)

Test suite run failed

Failed tests: 3/70. Failed suites: 1/3.
  ● UnpredictableNumberToolTest › validate legacy Java UN - mac

    assert.strictEqual(received, expected)

    Expected value to strictly be equal to:
      true
    Received:
      false

    Message:
      expected false to be true

      116 |     const unt: IUnpredictableNumberTool = UnpredictableNumberToolTest.createUnt("mac");
      117 |     let randomness = new Uint8Array([117, -106, -9, 48, 71, 18, -58, 36, -121, 69, 93, 120, -100, 100, -108, 104, -5, 67, 73, -36, -121, 79, -128, -128, -59, -119, -2, -86, -126, -36, 74, 117]);
    > 118 |     expect(unt.validateUnpredictableNumber("ABJ34us29mc=", randomness, BigInt(1977060911693))).true;
          |                                                                                               ^
      119 |   }
      120 |
      121 |   @test 'validate Java UN - mac'() {

      at UnpredictableNumberToolTest.validate legacy Java UN - mac (src/libs/UnpredictableNumberTool.test.ts:118:95)
      at Object.validate legacy Java UN - mac (node_modules/@testdeck/core/index.ts:180:27)

  ● UnpredictableNumberToolTest › validate Java UN - mac

    assert.strictEqual(received, expected)

    Expected value to strictly be equal to:
      true
    Received:
      false

    Message:
      expected false to be true

      122 |     const unt: IUnpredictableNumberTool = UnpredictableNumberToolTest.createUnt("mac");
      123 |     let randomness = new Uint8Array([28, -66, -9, -85, 78, -90, -64, -121, -111, 14, 93, -46, 65, -27, 64, 43, 75, -104, -121, -64, -67, -16, 4, -96, 66, -93, 99, 69, -89, -97, 39, -67]);
    > 124 |     expect(unt.validateUnpredictableNumber("llzLl_elSTv_64uII9FZGg==", randomness, BigInt(33198034831702))).true;
          |                                                                                                            ^
      125 |   }
      126 |
      127 |   @test 'validate Java UN - sig'() {

      at UnpredictableNumberToolTest.validate Java UN - mac (src/libs/UnpredictableNumberTool.test.ts:124:108)
      at Object.validate Java UN - mac (node_modules/@testdeck/core/index.ts:180:27)

  ● UnpredictableNumberToolTest › validate Java UN context - mac

    assert.strictEqual(received, expected)

    Expected value to strictly be equal to:
      true
    Received:
      false

    Message:
      expected false to be true

      134 |     const unt: IUnpredictableNumberTool = UnpredictableNumberToolTest.createUnt("mac");
      135 |     let randomness = new Uint8Array([28, -66, -9, -85, 78, -90, -64, -121, -111, 14, 93, -46, 65, -27, 64, 43, 75, -104, -121, -64, -67, -16, 4, -96, 66, -93, 99, 69, -89, -97, 39, -67]);
    > 136 |     expect(unt.validateUnpredictableNumber("mMfnOhRXj5iNz6_L-n3cOw==", randomness, BigInt(33198026955780), new Uint8Array([42]))).true;
          |                                                                                                                                  ^
      137 |   }
      138 |
      139 |   @test 'validate Java UN context - sig'() {

      at UnpredictableNumberToolTest.validate Java UN context - mac (src/libs/UnpredictableNumberTool.test.ts:136:130)
      at Object.validate Java UN context - mac (node_modules/@testdeck/core/index.ts:180:27)

Report generated by 🧪jest coverage report action from ca06e14

Copy link
Collaborator

@micwallace micwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleggrib oleggrib merged commit 65a7fef into main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants