Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: eas v1 offchain support #316

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

micwallace
Copy link
Collaborator

NOTE: Merge #312 first!!!

  • Update SDK and add support for v1 offchain attestations, with v0 backward compatibility
  • Migrate URL encoding functions to use latest EAS SDK and remove AttestationURL.ts
  • Return ethers tx object from revocation functions

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Test Results

  36 files    36 suites   20s ⏱️
473 tests 469 ✔️ 4 💤 0
477 runs  473 ✔️ 4 💤 0

Results for commit 94c8661.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Coverage report for src/main/javascript/crypto/

St.
Category Percentage Covered / Total
🟡 Statements
76.82% (-0.07% 🔻)
2528/3291
🔴 Branches
51.21% (+0.74% 🔼)
380/742
🟢 Functions
82.37% (-0.01% 🔻)
444/539
🟡 Lines
77.01% (-0.07% 🔻)
2486/3228
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / EasTicketAttestation.ts
81.19% (-0.32% 🔻)
68.24% (+2.45% 🔼)
82.93%
81.19% (-0.32% 🔻)
🟢
... / EasAttestedObject.ts
98.08%
58.33% (-5.3% 🔻)
100% 98.08%

Test suite run success

73 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 2837e66

@micwallace micwallace changed the base branch from main to stage September 6, 2023 09:31
Copy link
Collaborator

@oleggrib oleggrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @micwallace , I am happy with other code.

@micwallace micwallace merged commit a8c331e into stage Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants