Merge pull request #2392 from romainruaud/fix_virtual-category-filter…

…ing-29x

Prevent side effect when building widgets conditions based on virtual…

src/module-elasticsuite-virtual-category/Plugin/Collection/AddVirtualCategoryQuery.php

@@ -52,11 +52,14 @@ public function __construct(Provider $filterProvider)
      */
     public function beforeAddCategoryFilter(Collection $subject, Category $category)
     {
+        $category = clone $category; // Do not apply side-effect on the category itself.
+
         if ($category && $category->getData('is_virtual_category')) {
             $query = $this->filterProvider->getQueryFilter($category);
             if ($query !== null) {
                 $subject->addQueryFilter($query);
             }
+            // This is where cloning is useful. Otherwise, we could have a category without id later in the call stack.
             $category->setId(null);
         }