Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test is not Working. In Magento 2.4.5.p1 #2934

Closed
makwanamahesh-code opened this issue May 14, 2023 · 5 comments
Closed

Unit Test is not Working. In Magento 2.4.5.p1 #2934

makwanamahesh-code opened this issue May 14, 2023 · 5 comments

Comments

@makwanamahesh-code
Copy link

makwanamahesh-code commented May 14, 2023

When I run the unit test command for a core module I got the below error :

Screenshot from 2023-05-14 17-20-13 (1)

Preconditions

Unit Testing command

./vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist vendor/smile/elasticsuite/src/module-elasticsuite-core/Test/Unit/

Magento Version: 2.4.5.p-1 CE

ElasticSuite Version: 2.10.12.1

Environment: Developer

Third-party modules: No

Steps to reproduce

  1. Install Smile Module
  2. Run setup:upgrade command
  3. Then I run the Unit TEST command and it failed.

Expected result

  1. Install Smile Module
  2. Run setup:upgrade command
  3. Then I run the Unit TEST command and it's a success.

Actual result

  1. OutPut :
    Screenshot from 2023-05-14 17-20-13 (2) (1)
@makwanamahesh-code
Copy link
Author

I fixed Issue in this #2935

@romainruaud
Copy link
Collaborator

Hi @maheshmakwana-code

we run all the Unit Tests as part of our "Integration" pipeline, and they do not fail with Magento 2.4.5-p1

What's your PHP version ?

@romainruaud
Copy link
Collaborator

Ok we had a look and we now understand the issue.

The file should not be named "HistorgramTest" but rather be renamed to HistogramTest.

@makwanamahesh-code
Copy link
Author

PHP version 8.1 , Magento 2.4.5-p1 and Elasticsuite 2.11.x , I fixed this issue in #2935

romainruaud added a commit that referenced this issue May 16, 2023
@bhashkarkaragthiya
Copy link

Magento 2.4.x not supporting setup script but module still having it. will you please convert into patch and db_schema file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants