PHP 8.2 deprecated usage of 'Creation of dynamic property'

[hostep]

Preconditions

• PHP 8.2
• Magento Version: 2.4.6-p2
• ElasticSuite Version: 2.11.3.2
• Environment: dev
• Third party modules: many (but unrelated)

Steps to reproduce

1. In a Magento install with Elasticsuite version 2.11.3.2, run: vendor/bin/phpstan analyse --level=0 vendor/smile | grep 'Access to an undefined property

Expected result

1. No errors found

Actual result

1. Errors found:

$ vendor/bin/phpstan analyse --level=0 vendor/smile | grep 'Access to an undefined property'
 775/775 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

  41     Access to an undefined property Smile\ElasticsuiteTracker\Cron\CleanTrackingData::$helper.
  49     Access to an undefined property Smile\ElasticsuiteTracker\Cron\CleanTrackingData::$helper.
  108    Access to an undefined property Smile\ElasticsuiteVirtualCategory\Model\Url::$urlBuilder.

In theory this code should crash when being executed in PHP 8.2 because Magento's default error_reporting is set to not allow deprecated usages of code.

Extra

Similar issue was already reported before in #2835, and some fixes were done: here and here but not everything was fixed.

PHPstan is a great tool to use regularly to check the state of your code quality, maybe it can be added in your toolset of automated test checks (also adding bitexpert/phpstan-magento as dev dependency makes it easier to run tests and adds some extra rules on top of default phpstan specifically for magento)?

[hostep]

Thanks!