Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent side effect when building widgets conditions based on virtual… #2391

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Prevent side effect when building widgets conditions based on virtual… #2391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/module-elasticsuite-virtual-category/Plugin/Collection/AddVirtualCategoryQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,14 @@ public function __construct(Provider $filterProvider)
*/
public function beforeAddCategoryFilter(Collection $subject, Category $category)
{
$category = clone $category; // Do not apply side-effect on the category itself.

if ($category && $category->getData('is_virtual_category')) {
$query = $this->filterProvider->getQueryFilter($category);
if ($query !== null) {
$subject->addQueryFilter($query);
}
// This is where cloning is useful. Otherwise, we could have a category without id later in the call stack.
$category->setId(null);
}

Expand Down