Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not arbitrary cap the size of the collection to 20 items if no pag… #250

Merged
merged 1 commit into from
Dec 28, 2016

Conversation

romainruaud
Copy link
Collaborator

…e size is defined. Append a soft limit of 1000 items anyway.

This PR will fix #247 where the absence of _pageSize does cap the request size to 20 items.

It's hard to manage the 'all' parameter since Magento simply does not apply it when it's set, which results in the non-presence of the pageSize in the collection :

See the Magento's toolbar block

        $limit = (int)$this->getLimit();
        if ($limit) {
            $this->_collection->setPageSize($limit);
        }

…e size is defined. Append a soft limit of 1000 items anyway.
@afoucret afoucret merged commit e519a9f into Smile-SA:2.3.x Dec 28, 2016
@romainruaud romainruaud deleted the fix_page_size_cap branch January 25, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants