Fix mapping of sortable only fields. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
force-pushed
the
fix_sortable_mapping
branch
2 times, most recently
from
edc6d29 to
34fc3ce
Compare
afoucret
force-pushed
the
fix_sortable_mapping
branch
from
34fc3ce to
d1d7b1f
Compare
|
I have tested combinations both for reindexing and frontend navigation :
But the Travis build is broken (due to the Field class complexity). |
|
nevermind, Travis has been fixed and PR has been merged while I was writing my message :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fix #257.
@romainruaud : can you test all combination of attribute config is now valid.