Spellchecker : Fix multi index by alias error #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainruaud
reviewed
Feb 26, 2024
| // Compute the mtermvector query on all indices. | ||
| foreach (array_keys($stats['indices']) as $indexName) { | ||
| // Compute the mtermvector query on all shards to ensure exhaustive results. | ||
| foreach (range(0, $shards - 1) as $shard) { |
There was a problem hiding this comment.
If you have 2 indices having the same alias, and each of these indices having 3 shards.
What do you have in $shards at this step ? 6 ?
There was a problem hiding this comment.
Yes, but you don't have the information of which shard is assigned to which index
There was a problem hiding this comment.
hmmm so if I understand properly, if we have :
- index "aaaa" with 3 shards
- index "bbbb" with 3 shards
- they both share the "product" alias
In the end, in routing, we'll have :
- [aaaa][0], [aaaa][1], [aaaa][2], [aaaa][3], [aaaa][4], [aaaa][5]
- [bbbb][0], [bbbb][1], [bbbb][2], [bbbb][3], [bbbb][4], [bbbb][5]
And it will work even if shards 3 4 and 5 does not exist for these index ?
There was a problem hiding this comment.
Yes your example is correct and it seems to work properly even if the shard doesn't exist
|
OK for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.