Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change opensearch deps to make it compatible with magento 2.4.7-beta3 #3215

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Bashev
Copy link
Contributor

@Bashev Bashev commented Mar 16, 2024

I'm not sure why these limitation was set for version below 2.0.1, but this reflects to critical errors in magento 2.4.7-beta3 (and probably the final release).

I put the same requirements as they are in the Opensearch module in Magento https://github.com/magento/magento2/blob/b2286ecfb014dbe05a45004526541aa8250259c2/app/code/Magento/OpenSearch/composer.json#L12

@rbayet
Copy link
Collaborator

rbayet commented Mar 18, 2024

Hello @Bashev,

I'll let @romainruaud have a look, may'be this was cause by a specific issue in version 2.0.1 of the OpenSearch PHP client (which was obviously not the latest when we made the switch from the Elasticsearch PHP client to the OpenSearch one).

Regards,

@romainruaud
Copy link
Collaborator

I just copy pasted it from Magento 2.4.6 requirements guys :

https://github.com/magento/magento2/blob/2.4.6-p4/composer.json#L79

So I have no idea why they made this :)

@romainruaud romainruaud added the safe to test PR can be tested label Mar 26, 2024
@romainruaud romainruaud merged commit f5168a0 into Smile-SA:2.11.x Mar 26, 2024
10 checks passed
@hostep
Copy link
Contributor

hostep commented Apr 4, 2024

Hi @romainruaud: when can we expect a new release with this fix included? Would be great if this can happen somewhere in the next few days, so when Magento 2.4.7 is released on the 9th of April, this module will not cause upgrade issues.

Thanks! :)

For the people already trying out Magento 2.4.7-beta3, you can - for now - do something like this in your composer.jsonfile:

"smile/elasticsuite": "2.11.x-dev as 2.11.5.3",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test PR can be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants