[Catalog] Fix #2948, fallback to the last known valid product positions #3368
Conversation
| */ | ||
| private function unserializeProductPositions(\Magento\Catalog\Model\Category $category) | ||
| { | ||
| $productPositions = $category->getSortedProducts() ? $category->getSortedProducts() : []; | ||
| // Get product positions from the category. | ||
| $productPositions = $category->getSortedProducts(); |
There was a problem hiding this comment.
I don't understand why this line was changed but it does not seem to affect the behaviour of the feature or fix so far, even with multi-store and per-store view positions.
There was a problem hiding this comment.
The code now directly fetches product positions from the category using $category->getSortedProducts(). It will return either the current list of sorted products or null/an empty array if none are set. Therefore, there's no need to use a ternary operator to check and assign an empty array. Then if the data returned by $category->getSortedProducts() is not a valid JSON string (e.g., it's malformed or truncated), the jsonDecode() function will fail to parse it, the fallback is to use getProductPositionsByCategory($category). The warning message is displayed to notify the admin about the fallback, providing a clear indication that something went wrong.
There was a problem hiding this comment.
My point is about he ternary operator removal.
It will return either the current list of sorted products or null/an empty array if none are set.
Before, it would either return the currently submitted list of sorted product (in a not 100% determined format) or an empty array.
The only thing preventing to do a $category->setSortedProducts($productPositions); is the initial check if ($category->getId() && $category->getSortedProducts()) {.
|
Replaced by #3386 |
No description provided.