Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty children status. #567

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Conversation

afoucret
Copy link
Contributor

Fix for #565

@afoucret afoucret merged commit 2456db1 into Smile-SA:2.3.x Oct 17, 2017
@srenon
Copy link

srenon commented Oct 17, 2017

@afoucret .... This commit will cause products to not show up because it will return false if status does not exist hence removing the product.

This code works better for me ...

            if(array_key_exists('status', $childrenData)){
                $enabled = current($childrenData['status']) == 1;
                if ($enabled === false) {
                    unset($childrenIndexData[$childrenId]);
                }
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants