-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confine pointer #76
Conversation
Hi, thanks for working on this! Before all, could you explain me why you merged this logic with the |
Well because frames (and not window module) are holding references to WlPointer right now, so I thought that would be more convenient. |
A SCTK user would normally also have a In this approach, I guess we could have some API allowing the app to constrain a given pointer to a given surface, something like that. |
Ok, so |
I think ideally this code should be separated into its own module (like the |
In this case there is no need to even implement API for that purpose since all you need to do is call one method (whether it is |
I'm going to close this, given this appear to need more design thought. Please head to #77 if you want to discuss this further. :) |
Resolves #72. It doesn't look good right now, and I didn't add the ability to grab pointer for new seats that can be added after pointer grab yet, since it requires providing
new_seat
method with surface reference.