Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smallvil fixes 2 #1100

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Smallvil fixes 2 #1100

merged 3 commits into from
Aug 15, 2023

Conversation

YaLTeR
Copy link
Contributor

@YaLTeR YaLTeR commented Aug 15, 2023

This time: fix clipboard and add basic popup support.

YaLTeR added 3 commits August 15, 2023 14:27
Will be useful for the data device focus.
Makes clipboard work across clients.
Doesn't handle popup grabs but gets smallvil far enough.
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c569c87) 24.01% compared to head (e8cca38) 24.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   24.01%   24.01%           
=======================================
  Files         140      140           
  Lines       21591    21591           
=======================================
  Hits         5184     5184           
  Misses      16407    16407           
Flag Coverage Δ
wlcs-buffer 21.03% <ø> (ø)
wlcs-core 20.66% <ø> (ø)
wlcs-output 8.46% <ø> (ø)
wlcs-pointer-input 22.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

smallvil/src/handlers/compositor.rs Outdated Show resolved Hide resolved
@YaLTeR YaLTeR force-pushed the smallvil-fixes-2 branch 2 times, most recently from ee797fa to e8cca38 Compare August 15, 2023 13:40
Copy link
Member

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Popups support in Smallvil was long overdue, so it's great to see it.

@PolyMeilex PolyMeilex merged commit e241ccb into Smithay:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants