-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glow
to 0.14
#1195
Update glow
to 0.14
#1195
Conversation
Hm, looking at the clippy error, it seems a change, in particular grovesNL/glow@d62451c7, make Show |
It is kinda right for glow to not explicitly implement those, given that this depends on the platform and even on unix this is not clear cut. As long as the context is only made current on one thread at a time, you can move it around, but otherwise stuff breaks. So I guess it would be more correct for our wrapper to implement Send/Sync and make sure to uphold that invariant. |
Yeah, so using it with multiple threads can be unsafe. But So I guess it's a matter of taste whether or not such a type should be |
I'm trying to upgrade the egui and egui-glow dependencies in |
I guess we're still waiting for glow 0.14 to fix the |
`smithay-egui` also needs to be updated with `egui-glow` 0.29 to match.
Updated to 0.14, and updated Smithay/smithay-egui#16. |
No description provided.