Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Begone delegate macros #1327

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PolyMeilex
Copy link
Member

@PolyMeilex PolyMeilex commented Feb 12, 2024

Based on Smithay/wayland-rs#699

Removes all delegate macros, as well as redundant type constraints on D

Both this PR as well as wayland-rs part attempt to be non-braking changes, the transition should be smooth 🤞

@ids1024
Copy link
Member

ids1024 commented Feb 12, 2024

This should genuinely make adding a simple protocol to Smithay take about half as much effort as it currently does. (The less annoying half.) It's great to see we can do this without radically changing the API!

@PolyMeilex PolyMeilex force-pushed the begone-delegate-macros branch from b27cb8e to e58193b Compare February 25, 2024 02:02
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 30.74935% with 268 lines in your changes are missing coverage. Please review.

Project coverage is 20.52%. Comparing base (b62ced7) to head (e58193b).

Files Patch % Lines
src/wayland/seat/pointer.rs 0.00% 33 Missing ⚠️
src/wayland/pointer_gestures.rs 0.00% 17 Missing ⚠️
src/wayland/pointer_constraints.rs 13.33% 13 Missing ⚠️
src/wayland/dmabuf/dispatch.rs 0.00% 11 Missing ⚠️
src/wayland/compositor/tree.rs 58.33% 10 Missing ⚠️
src/wayland/idle_notify/mod.rs 0.00% 10 Missing ⚠️
src/wayland/selection/wlr_data_control/mod.rs 16.66% 10 Missing ⚠️
src/wayland/shell/xdg/decoration.rs 37.50% 10 Missing ⚠️
src/wayland/dmabuf/mod.rs 30.76% 9 Missing ⚠️
src/wayland/viewporter/mod.rs 18.18% 9 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
- Coverage   20.55%   20.52%   -0.04%     
==========================================
  Files         158      159       +1     
  Lines       25868    25873       +5     
==========================================
- Hits         5317     5310       -7     
- Misses      20551    20563      +12     
Flag Coverage Δ
wlcs-buffer 17.91% <28.94%> (-0.05%) ⬇️
wlcs-core 17.55% <28.94%> (-0.07%) ⬇️
wlcs-output 7.37% <20.67%> (-0.16%) ⬇️
wlcs-pointer-input 19.37% <28.94%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants