Skip to content

Commit

Permalink
Merge pull request #59 from Snailedlt/feature/check_if_pr_base_is_dev…
Browse files Browse the repository at this point in the history
…elop

remove not
  • Loading branch information
Snailedlt authored Oct 15, 2022
2 parents b76fa82 + 5b33d55 commit 00ebbda
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/scripts/check_icon_pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def main():
pr_err_msg = ""
pr_data = api_handler.get_pull_req(args.token, args.pr_number)
pr_base_branch = api_handler.get_pr_base_branch(pr_data)
if not pr_base_branch != "develop":
if pr_base_branch != "develop":
pr_err_msg.append(f"The PR's base branch is `{pr_base_branch}`, but should be `develop`, please change the PR so that it's based on, and merged into `develop`")

all_icons = filehandler.get_json_file_content(args.devicon_json_path)
Expand Down

0 comments on commit 00ebbda

Please sign in to comment.