Repo update to Camera Kit SDK version 1.34.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ prepare_react_native_project! | |||
| # dependencies: { | |||
| # ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}), | |||
| # ``` | |||
| flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled | |||
| # flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled | |||
There was a problem hiding this comment.
what is flipper config?
There was a problem hiding this comment.
Per official recommendation, I am disabling flipper "The workaround, for the time being, is to disable Flipper."
More about flipper: https://fbflipper.com/
There was a problem hiding this comment.
should we just remove flipper code then?
There was a problem hiding this comment.
Let's leave it for now as it might be a useful resource for someone who would want to implement a workaround with header file. We can remove it in one of the future updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background (Why?)
To update the repo to the latest version of the Camera Kit SDK - 1.34.0
Change/Solution (What?)
Called object type 'facebook::flipper::SocketCertificateProvider' (aka 'int') is not a function or function pointerfacebook/react-native#43335Screenshots for any visual changes
N/A
Test Plans
Manually validated on iOS and Android device