Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Cosine and Jaccard Similarity classes #6

Open
wants to merge 9 commits into
base: bootstrap
Choose a base branch
from

Conversation

muratcancicek
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 26, 2024

size-limit report 📦

Path Size
dist/crunchdb.cjs.production.min.js 3.55 KB (+5.16% 🔺)
dist/crunchdb.esm.js 2.9 KB (+6.23% 🔺)

Copy link

@sdmuki sdmuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look great. I will change the interfaces to return ResultAsync types instead. You can change the implementations after that

src/implementations/ranking/CosineSimilarity.ts Outdated Show resolved Hide resolved
@muratcancicek muratcancicek added the bug Something isn't working label Apr 30, 2024
@muratcancicek muratcancicek removed the bug Something isn't working label Apr 30, 2024
@muratcancicek muratcancicek requested a review from sdmuki May 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants