Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Current Session ID #245

Merged

Conversation

opodoprigora
Copy link
Contributor

Log Current Session ID

@opodoprigora
Copy link
Contributor Author

Based on feature #243

@opodoprigora opodoprigora marked this pull request as ready for review April 4, 2024 20:45
@opodoprigora
Copy link
Contributor Author

@sfc-gh-twhite please take a look when ever you have a chance.

@sfc-gh-twhite
Copy link
Collaborator

Thank you for the PR!

I would opt to use the session_id that is available from the property of the Snowflake connection. For example, we can do this:

import snowflake.connector

con = snowflake.connector.connect()

print(con.session_id)

I believe that avoids the extra query submission. :)

@opodoprigora
Copy link
Contributor Author

@sfc-gh-twhite good call 💪 , updated.

@sfc-gh-twhite
Copy link
Collaborator

Awesome job! We're doing a good bit of overhauling from a maintenance perspective of this project, but hopefully we can get this one in soon.

@sfc-gh-tmathew sfc-gh-tmathew changed the base branch from master to dev April 11, 2024 02:52
@sfc-gh-tmathew sfc-gh-tmathew added enhancement New feature or request Development in Progress Will be addressed in upcoming release labels Apr 11, 2024
@sfc-gh-tmathew sfc-gh-tmathew merged commit ac257a2 into Snowflake-Labs:dev Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development in Progress Will be addressed in upcoming release enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants