Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Demo deployment tests #248

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Include Demo deployment tests #248

merged 7 commits into from
Apr 16, 2024

Conversation

sfc-gh-tmathew
Copy link
Collaborator

  • Updated test case coverage
  • Adds Session id to the output (External Contribution)
  • Includes pytest + testing citibike demo against internal snowflake instance
  • Removes dependency for pandas (External Contribution)
  • addresses bug of warehouse missing from context.

@sfc-gh-jhansen sfc-gh-jhansen marked this pull request as ready for review April 16, 2024 05:09
@sfc-gh-tmathew sfc-gh-tmathew merged commit dbbf820 into dev Apr 16, 2024
2 checks passed
@sfc-gh-tmathew sfc-gh-tmathew deleted the feature/test_demo branch April 16, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jhansen sfc-gh-jhansen sfc-gh-jhansen approved these changes

@sfc-gh-twhite sfc-gh-twhite Awaiting requested review from sfc-gh-twhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-tmathew @sfc-gh-jhansen