Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Grant DATASETS usage to a role through terraform #2807

Closed
1 task
GomathiMa opened this issue May 15, 2024 · 5 comments
Closed
1 task

[Feature]: Grant DATASETS usage to a role through terraform #2807

GomathiMa opened this issue May 15, 2024 · 5 comments
Assignees
@sfc-gh-jcieslak
Labels
category:grants feature-request Used to mark issues with provider's missing functionalities

Comments

@GomathiMa
Copy link

Use Cases or Problem Statement

Unable to see the terraform script/syntax for below snowflake grants

GRANT USAGE ON FUTURE DATASETS IN SCHEMA IDENTIFIER($SCHEMA_FQN) TO ROLE IDENTIFIER($FS_ROLE_CONSUMER);
GRANT USAGE ON ALL DATASETS IN IDENTIFIER($SCHEMA_FQN) TO ROLE IDENTIFIER($FS_ROLE_CONSUMER);

Category

category:grants

Object type(s)

resource:grant_privileges_to_account_role

Proposal

No response

How much impact is this issue causing?

Medium

Additional Information

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@GomathiMa GomathiMa added the feature-request Used to mark issues with provider's missing functionalities label May 15, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @GomathiMa 👋
I'm not familiar with dataset objects, also couldn't find them in the documentation. Is that a preview feature?

@GomathiMa
Copy link
Author

I think, that is a preview feature

@sfc-gh-jcieslak
Copy link
Collaborator

Hey, I'll try to add it with some other changes. I'll let you know when it will be released.

@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this issue May 27, 2024
Merged
1 task
sfc-gh-jcieslak added a commit that referenced this issue May 29, 2024
@sfc-gh-jcieslak
feat: Database resource v1 readiness (#2834)
30fe136 
Changes done:
- Added two resources `snowflake_shared_database` and
`snowflake_secondary_database`
- Added nested objects for hierarchical values (Optional and Computed)
like `data_retention_time_in_days` and `max_data_extension_time_in_days`
- Also added a customdiff for nested objects that are hierarchical
values, so that they're refreshed correctly (checked by acceptance test
for secondary database)
- Added privilege requested in
#2807
- Wrote diff suppress functions for LogLevel and TraceLevel fields,
because unset value is always equal to `OFF`, so diff suppress is needed
in a case where no value is set (empty string) and `OFF` is set in the
Read operation.

Not sure about:
- I'm not sure about identifier field names (e.g. `external_volume` or
`external_volume_name`)
- Not sure about external identifier names (`from_share` and
`as_replica_of`)

Next:
- Standard database resource
- Data source
- Address listed issues

## Test Plan
* [x] acceptance tests testing 

## References
<!-- issues documentation links, etc  -->

* [Create
database](https://docs.snowflake.com/en/sql-reference/sql/create-database)
sfc-gh-jmichalak pushed a commit that referenced this issue May 31, 2024
@sfc-gh-jcieslak @sfc-gh-jmichalak
feat: Database resource v1 readiness (#2834)
ca52209 
Changes done:
- Added two resources `snowflake_shared_database` and
`snowflake_secondary_database`
- Added nested objects for hierarchical values (Optional and Computed)
like `data_retention_time_in_days` and `max_data_extension_time_in_days`
- Also added a customdiff for nested objects that are hierarchical
values, so that they're refreshed correctly (checked by acceptance test
for secondary database)
- Added privilege requested in
#2807
- Wrote diff suppress functions for LogLevel and TraceLevel fields,
because unset value is always equal to `OFF`, so diff suppress is needed
in a case where no value is set (empty string) and `OFF` is set in the
Read operation.

Not sure about:
- I'm not sure about identifier field names (e.g. `external_volume` or
`external_volume_name`)
- Not sure about external identifier names (`from_share` and
`as_replica_of`)

Next:
- Standard database resource
- Data source
- Address listed issues

## Test Plan
* [x] acceptance tests testing 

## References
<!-- issues documentation links, etc  -->

* [Create
database](https://docs.snowflake.com/en/sql-reference/sql/create-database)
@sfc-gh-jmichalak sfc-gh-jmichalak mentioned this issue Jul 1, 2024
Closed
1 task
@sfc-gh-jcieslak sfc-gh-jcieslak self-assigned this Sep 2, 2024
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this issue Sep 2, 2024
Merged
sfc-gh-jcieslak added a commit that referenced this issue Sep 3, 2024
@sfc-gh-jcieslak
fix: minor issues (#3027)
467b06e 
## Addressed issues
* #3016 `SHOW ORGANIZATION ACCOUNTS` -> `SHOW ACCOUNTS` BCR
* #3015
* #2807
* #3025
@snowflake-release-please snowflake-release-please bot mentioned this issue Sep 3, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this issue Sep 4, 2024
@snowflake-release-please
chore(main): release 0.95.0 (#2977)
cd1636c 
🤖 I have created a release *beep* *boop*
---


##
[0.95.0](v0.94.1...v0.95.0)
(2024-09-04)


### 🎉 **What's new:**

* Add change_tracking, row access policy and aggregation policy to views
([#2988](#2988))
([1f88bb1](1f88bb1))
* Add fully_qualified_name to all resources
([#2990](#2990))
([1b0462f](1b0462f))
* Add identifier parsers
([#2957](#2957))
([824ec52](824ec52))
* Add identifier with arguments
([#2979](#2979))
([00ae1c5](00ae1c5))
* Add timeouts block to cortex
([#3004](#3004))
([34d764b](34d764b))
* Add user parameters to resource
([#2968](#2968))
([f4ae380](f4ae380))
* Conclude user rework
([#3036](#3036))
([23e4625](23e4625))
* database role v1 readiness
([#3014](#3014))
([c4db255](c4db255))
* Identifier with arguments for procedure and external function
([#2987](#2987))
([f13cc5c](f13cc5c))
* Rework user resource
([#3026](#3026))
([bde2638](bde2638)),
closes
[#1572](#1572)
* Rework users datasource
([#3030](#3030))
([751239b](751239b)),
closes
[#2902](#2902)
* Upgrade view sdk
([#2969](#2969))
([ef2d50a](ef2d50a))
* View rework part 2
([#3021](#3021))
([e05377d](e05377d))
* View rework part 3
([#3023](#3023))
([195b41c](195b41c))


### 🔧 **Misc**

* Add annotation about fully_qualified_name and fix handling granteeName
([#3009](#3009))
([94e6345](94e6345))
* Apply identifier conventions
([#2996](#2996))
([5cbea84](5cbea84))
* apply identifier conventions to grants
([#3008](#3008))
([d7780ae](d7780ae))
* Clean collection utils
([#3028](#3028))
([426ddb1](426ddb1))
* Clean old assertions
([#3029](#3029))
([ad657eb](ad657eb))
* Conclude identifiers rework
([#3011](#3011))
([c1b53f3](c1b53f3))
* Improve user test and add manual test for user default database and
role
([#3035](#3035))
([6cb0b4e](6cb0b4e))
* Use new identifier with arguments in function, external function and
procedure grants
([#3002](#3002))
([5053f8b](5053f8b))
* User improvements
([#3034](#3034))
([65b64d7](65b64d7))


### 🐛 **Bug fixes:**

* database tests and introduce a new parameter
([#2981](#2981))
([3bae7f6](3bae7f6))
* Fix custom diffs for fields with diff supression
([#3032](#3032))
([2499602](2499602))
* Fix default secondary roles after BCR 2024_07
([#3040](#3040))
([2ca465a](2ca465a)),
closes
[#3038](#3038)
* Fix issues 2972 and 3007
([#3020](#3020))
([1772387](1772387))
* Fix known user resource issues
([#3013](#3013))
([a5dfeac](a5dfeac))
* identifier issues
([#2998](#2998))
([6fb76b7](6fb76b7))
* minor issues
([#3027](#3027))
([467b06e](467b06e)),
closes
[#3015](#3015)
[#2807](#2807)
[#3025](#3025)
* Nuke users
([#2971](#2971))
([0d90cc9](0d90cc9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
@sfc-gh-jcieslak
Copy link
Collaborator

sfc-gh-jcieslak commented Sep 5, 2024 •
edited
Loading

Hey @GomathiMa 👋
Yesterday, we released a new provider version (v0.95.0). Please upgrade and let us know if now you can grant privileges on future datasets.

@sfc-gh-jcieslak
Copy link
Collaborator

Closing due to long inactivity. Please, create another issue if you think the problem is still not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-jcieslak sfc-gh-jcieslak

Labels
category:grants feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GomathiMa @sfc-gh-jcieslak