Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Random ids rework part4 #2837

Merged
merged 13 commits into from
May 29, 2024
Merged

chore: Random ids rework part4 #2837

merged 13 commits into from
May 29, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

Do not use the following methods for id creation in tests:

  • NewDatabaseObjectIdentifier
  • NewDatabaseObjectIdentifierFromFullyQualifiedName
  • NewSchemaObjectIdentifierInSchema
  • NewSchemaObjectIdentifier
  • NewSchemaObjectIdentifierWithArguments
  • NewSchemaObjectIdentifierFromFullyQualifiedName

@sfc-gh-asawicki sfc-gh-asawicki changed the title Random ids rework part4 chore: Random ids rework part4 May 27, 2024
Copy link

Integration tests failure for 386bb45695480b404363f9af20d22f7e8ce2e5f2

Copy link

Integration tests failure for a052f34af0a8d777286bfdfd91c31781ada3239e

Copy link

Integration tests cancelled for 350a1f7953f687ef9f4e73eac4dc8ecf741c36c5

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the random-ids-rework-part4 branch from 350a1f7 to b23e0cd Compare May 28, 2024 10:53
Copy link

Integration tests success for b23e0cd22266cf4649e9b604c850365620bc019b

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review May 28, 2024 14:12
pkg/resources/grant_database_role_acceptance_test.go Outdated Show resolved Hide resolved
pkg/sdk/test_ids_test.go Outdated Show resolved Hide resolved
pkg/sdk/policy_references_test.go Outdated Show resolved Hide resolved
pkg/sdk/random_test.go Show resolved Hide resolved
Copy link

Integration tests success for 3fba21ff815b4364994e2c513ea49e0bb3225d63

Copy link

Integration tests success for 57a51c824791b7479e94cf8adcaece5dbaaba899

@sfc-gh-asawicki sfc-gh-asawicki merged commit 64518a3 into main May 29, 2024
9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the random-ids-rework-part4 branch May 29, 2024 11:46
sfc-gh-jmichalak pushed a commit that referenced this pull request May 31, 2024
Do not use the following methods for id creation in tests:
- NewDatabaseObjectIdentifier
- NewDatabaseObjectIdentifierFromFullyQualifiedName
- NewSchemaObjectIdentifierInSchema
- NewSchemaObjectIdentifier
- NewSchemaObjectIdentifierWithArguments
- NewSchemaObjectIdentifierFromFullyQualifiedName
sfc-gh-jcieslak pushed a commit that referenced this pull request Jun 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.92.0](v0.91.0...v0.92.0)
(2024-06-06)


### 🎉 **What's new:**

* Add Api Authentication security integration to sdk
([#2840](#2840))
([57a07ee](57a07ee))
* Add External Oauth security integration to sdk
([#2835](#2835))
([82d1c09](82d1c09))
* add network rules
([#2746](#2746))
([c79fa29](c79fa29))
* Add SCIM and SAML2 security integrations to sdk
([#2799](#2799))
([1312ff1](1312ff1))
* Add Snowflake Oauth security integration to sdk
([#2830](#2830))
([b576f29](b576f29))
* Database resource v1 readiness
([#2834](#2834))
([30fe136](30fe136))
* Database SDK upgrade
([#2814](#2814))
([750fe37](750fe37))


### 🔧 **Misc**

* accept non-pointer values in the generated builder methods
([#2816](#2816))
([c29fbf1](c29fbf1))
* Add a script for creating labels
([#2778](#2778))
([ce0fbad](ce0fbad))
* Adjust before 0.92.0
([#2857](#2857))
([0598656](0598656))
* Continue random ids rework
([#2819](#2819))
([f20940c](f20940c))
* Random ids rework part3
([#2833](#2833))
([36ead85](36ead85))
* Random ids rework part4
([#2837](#2837))
([64518a3](64518a3))
* Update issue for table and warehouse redesign state
([#2845](#2845))
([149e55e](149e55e))


### 🐛 **Bug fixes:**

* Fix failing integration tests
([#2832](#2832))
([2e2ca6c](2e2ca6c))
* Fix QUOTED_IDENTIFIERS_IGNORE_CASE parameter test
([#2841](#2841))
([92ad1d3](92ad1d3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants