chore: accept non-pointer values in the generated builder methods #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for bd8d809ee7612819acb9b95148a3091e3eb35e83 |
|
Integration tests failure for 80b144620de460713311641db994d33ea12ce1f9 |
|
Integration tests failure for e7497c8de398dc0826300ac7facd53573304386c |
|
Integration tests failure for 7c2c2e649541fbe33566c723762f482d5463c572 |
sfc-gh-asawicki
requested changes
May 17, 2024
|
Integration tests failure for 7c27fe1049fa448a92e5b2eefdd6e9c2c9277446 |
sfc-gh-asawicki
approved these changes
May 20, 2024
sfc-gh-jmichalak
approved these changes
May 20, 2024
2 tasks
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.92.0](v0.91.0...v0.92.0) (2024-06-06) ### 🎉 **What's new:** * Add Api Authentication security integration to sdk ([#2840](#2840)) ([57a07ee](57a07ee)) * Add External Oauth security integration to sdk ([#2835](#2835)) ([82d1c09](82d1c09)) * add network rules ([#2746](#2746)) ([c79fa29](c79fa29)) * Add SCIM and SAML2 security integrations to sdk ([#2799](#2799)) ([1312ff1](1312ff1)) * Add Snowflake Oauth security integration to sdk ([#2830](#2830)) ([b576f29](b576f29)) * Database resource v1 readiness ([#2834](#2834)) ([30fe136](30fe136)) * Database SDK upgrade ([#2814](#2814)) ([750fe37](750fe37)) ### 🔧 **Misc** * accept non-pointer values in the generated builder methods ([#2816](#2816)) ([c29fbf1](c29fbf1)) * Add a script for creating labels ([#2778](#2778)) ([ce0fbad](ce0fbad)) * Adjust before 0.92.0 ([#2857](#2857)) ([0598656](0598656)) * Continue random ids rework ([#2819](#2819)) ([f20940c](f20940c)) * Random ids rework part3 ([#2833](#2833)) ([36ead85](36ead85)) * Random ids rework part4 ([#2837](#2837)) ([64518a3](64518a3)) * Update issue for table and warehouse redesign state ([#2845](#2845)) ([149e55e](149e55e)) ### 🐛 **Bug fixes:** * Fix failing integration tests ([#2832](#2832)) ([2e2ca6c](2e2ca6c)) * Fix QUOTED_IDENTIFIERS_IGNORE_CASE parameter test ([#2841](#2841)) ([92ad1d3](92ad1d3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
sfc-gh-asawicki
pushed a commit
that referenced
this pull request
Jun 23, 2024
Changes done: - Templates were moved to files, so that - We get proper highlighting from IDE - We get help with model type and fields or methods inside it + ability to go to definition and more (https://blog.jetbrains.com/go/2018/12/14/go-templates-made-easy/) - Reorganized into smaller chunks, so it should be easier to navigate (main templates are in the `templates` directory, and helper templates used inside the main ones are kept inside the `subtemplates` directory). - In the `templates.go` now all of the templates are loaded by embed, except the ones that use other templates which have to be initiated in `func init()`. - All of the testing was made on the `managed account` resource and it shouldn't collide with #2816 - Also, there were made small adjustments like - Checking for operation name inside unit tests so we won't make invalid Show test - Mapping adjusted to the changes made in #2816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept non-pointer values in the generated builder methods. Now the nested requests have to be explicitly unreferenced, but two additional cases could be added to resolve this "issue". There's only a special case for strings which shouldn't be set whenever they're optional and the input value is equal to an empty string, because:
The improved generator was tested and used as an example on the external table.