feat: databases sdk v2 #1840
Merged
feat: databases sdk v2 #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Integration tests failure for 7e73a8ea407f452d1341829eb930d81cc882409a |
|
Integration tests failure for 0fdc388ce8b97ae1641185a6ae7896f06aa242b6 |
|
Integration tests failure for 94bfed1dd28b446ae8b9a00c097bdbedb4a3df2b |
|
Integration tests failure for 25bd7aa03f675bc00ba1fc990c517cac50fcf4b8 |
|
|
||
| "github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/snowflake" | ||
| "github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
import 'github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk' is not allowed from list 'Main' (depguard)
|
Integration tests failure for 5325cdc5d11ac9207e0039fc826f9c5506d4edbd |
|
Integration tests failure for 7675f14c7499346c6024377b78212c33a53761fc |
|
Integration tests success for 1eecb7d6f3f94c524e5cf684af6cd4e98515fb78 |
adoankim
pushed a commit
to adoankim/terraform-provider-snowflake
that referenced
this pull request
Jun 15, 2023
* fix minor things * linting fixes and make docs * sweepers fix for roles * rename symbols * databases int test for show * add databases to sdk v2 * fix linting error * databases to sdk v2 * fix unit tests spacing * fix sql builder tests * fix tag acc test * remove depguard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add databases to sdk v2. Still need to finish integration tests.