Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix cortex search service #2904

Merged
merged 9 commits into from
Jul 2, 2024
Merged

fix: Fix cortex search service #2904

merged 9 commits into from
Jul 2, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

  • fix integration tests
  • fix datasource (multiple errors)
  • add missing force news
  • add missing examples and imports
  • add disclaimer
  • fix resource logic
  • skip resource test (error with no db in session)
  • fix datasource acceptance test
  • fix docs around grants
  • add tests for grants (normal, plural, and ownership)

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review July 2, 2024 10:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Integration tests failure for 8e4e7535f2814da4bf7326c66a3e581e064bdc51

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Integration tests cancelled for 53cee88bebccc8b37421167099f21d40686d57a0

sfc-gh-jcieslak
sfc-gh-jcieslak approved these changes Jul 2, 2024
View reviewed changes
docs/resources/cortex_search_service.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Integration tests failure for 28deb9ed32ef3c623cfdecf8ff79b02178ea0ced

@sfc-gh-asawicki sfc-gh-asawicki merged commit 763d06c into main Jul 2, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-cortex-search-service branch July 2, 2024 13:03
@snowflake-release-please snowflake-release-please bot mentioned this pull request Jul 1, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 10, 2024
@snowflake-release-please
chore(main): release 0.93.0 (#2866)
ad74736 
🤖 I have created a release *beep* *boop*
---


##
[0.93.0](v0.92.0...v0.93.0)
(2024-07-10)


### 🎉 **What's new:**

* Add OAUTH integration for custom clients
([#2908](#2908))
([d9b557f](d9b557f))
* Add oauth integration for partner applications
([#2912](#2912))
([91788e5](91788e5))
* Add support for cortex search service
([#2860](#2860))
([43aa89f](43aa89f))
* API Authentication integration v1 readiness
([#2898](#2898))
([91931da](91931da))
* External Oauth integration v1 readiness
([#2907](#2907))
([ed237c3](ed237c3))
* Generate show outputs with mappers
([#2886](#2886))
([1cada88](1cada88))
* Introduce security integrations datasource
([#2892](#2892))
([7f6c657](7f6c657))
* SAML2 integration v1 readiness
([#2868](#2868))
([d0c136d](d0c136d))
* SCIM integration v1 readiness
([#2846](#2846))
([269df6b](269df6b))
* Security integrations datasource v1 readiness
([#2913](#2913))
([d10474a](d10474a))
* standard database v1 readiness
([#2842](#2842))
([3c11953](3c11953))
* Warehouse redesign final touches
([#2900](#2900))
([0eab636](0eab636))
* Warehouse redesign part1
([#2864](#2864))
([6664457](6664457))
* Warehouse redesign part2
([#2887](#2887))
([1aaf417](1aaf417))
* Warehouse redesign part3
([#2890](#2890))
([873a1ed](873a1ed))
* Warehouse redesign part4
([#2893](#2893))
([d525fd9](d525fd9))


### 🔧 **Misc**

* Add documentation on unset and defaults
([#2882](#2882))
([85a7836](85a7836))
* apply minor database changes
([#2872](#2872))
([6ccac59](6ccac59))
* Apply new resource conventions to scim integration
([#2891](#2891))
([e11e608](e11e608))
* Improve generator template organization
([#2820](#2820))
([5035e2f](5035e2f))
* Nuke stale objects
([#2869](#2869))
([9c4a117](9c4a117))
* Show a possible solution for
[#2877](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2877)
([#2878](#2878))
([6fb437b](6fb437b))
* Validations cleanup and old grants removal
([#2884](#2884))
([05b7eee](05b7eee))


### 🐛 **Bug fixes:**

* Add disclaimers and fix tests
([#2905](#2905))
([1deaedc](1deaedc))
* Fix cortex search service
([#2904](#2904))
([763d06c](763d06c))
* use suppressQuoting to fix stage file_format permadiff
([#2885](#2885))
([fd70f6e](fd70f6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-jmichalak sfc-gh-jmichalak Awaiting requested review from sfc-gh-jmichalak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak