-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts V3 #50
Contracts V3 #50
Conversation
@@ -386,7 +384,7 @@ impl ExportXcm for BridgeHubRococoOrBridgeHubWococoSwitchExporter { | |||
destination, | |||
message, | |||
) | |||
.map(|result| ((EthereumNetwork::get(), result.0), result.1)) | |||
.map(|result| ((EthereumNetwork::get(), (result.0, XcmHash::default())), result.1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because SnowbridgeExporter::validate
no longer returns the XcmHash
. Not sure what the solution is here, I think @vgeddes mentioned in a newer version of Substrate the other validators also do not return the XcmHash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah returning XcmHash::default
is fine here.
When we upgrade to the latest cumulus it will all be fine.
@claravanstaden Actually, you should merge this PR into the |
6ae081f
to
85da228
Compare
* Fix cumulus builds * Update cumulus (#46) * Create Agent (#47) * add hashed description * use existing account * add call filter * Create Agent (#48) * initial * update cargo lock * handle local accounts and pallets * Add set_gateway to safe call filter (#49) * Fix cumulus bridgehub runtime for proxy contracts. (#50) Co-authored-by: claravanstaden <Cats 4 life!> * Update inbound queue benchmarks. (#51) * Update inbound queue benchmarks. * Update inbound queue benchmarks. --------- Co-authored-by: claravanstaden <Cats 4 life!> * Asset transfer (#52) * update registry to gateway * added agent config * ws * increase message size --------- Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
* Fix cumulus builds * Update cumulus (#46) * Create Agent (#47) * add hashed description * use existing account * add call filter * Create Agent (#48) * initial * update cargo lock * handle local accounts and pallets * Add set_gateway to safe call filter (#49) * Fix cumulus bridgehub runtime for proxy contracts. (#50) Co-authored-by: claravanstaden <Cats 4 life!> * Update inbound queue benchmarks. (#51) * Update inbound queue benchmarks. * Update inbound queue benchmarks. --------- Co-authored-by: claravanstaden <Cats 4 life!> * Asset transfer (#52) * update registry to gateway * added agent config * ws * increase message size * added weights --------- Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Snowbridge companion: Snowfork/snowbridge#882