Register token with inbound fixture #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,7 +100,7 @@ pub mod accounts { | |||
| pub const CHARLIE: &str = "Charlie"; | |||
| pub const DAVE: &str = "Dave"; | |||
| pub const EVE: &str = "Eve"; | |||
| pub const FERDIE: &str = "Ferdei"; | |||
| pub const FERDIE: &str = "Ferdie"; | |||
Comment on lines
+203
to
+214
| EthereumBeaconClient::store_execution_header( | ||
| register_asset_message.message.proof.block_hash, | ||
| register_asset_message.execution_header, | ||
| 0, | ||
| H256::default(), | ||
| ); | ||
|
|
||
| EthereumInboundQueue::submit( | ||
| RuntimeOrigin::signed(BridgeHubRococoSender::get()), | ||
| register_asset_message.message, | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
Hmmm I'm not sure this change is a good one. What do you think is the benefit of changing this? I feel like the previous way is clearer to read and understand what is happening, imo.
There was a problem hiding this comment.
To not expose the internal implementation details to the tests.
More context in Snowfork/snowbridge#1115 (comment)
claravanstaden
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Register token with inbound fixture * Import snowbridge-pallet-inbound-queue-fixtures * Cleanup Cargo.toml * Update emulated test * Fix emulated test * Rename to register_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.