Polkadot assets on ethereum #128

yrong · 2024-03-21T14:29:41Z

No description provided.

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs

bridges/snowbridge/pallets/system/src/lib.rs

alistair-singh · 2024-04-03T10:38:20Z

bridges/snowbridge/pallets/system/src/lib.rs

@@ -243,6 +253,10 @@ pub mod pallet {
 	pub type PricingParameters<T: Config> =
 		StorageValue<_, PricingParametersOf<T>, ValueQuery, T::DefaultPricingParameters>;

+	#[pallet::storage]
+	#[pallet::getter(fn tokens)]
+	pub type Tokens<T: Config> = StorageMap<_, Twox64Concat, TokenId, Location, OptionQuery>;


Ditto. Location version is implicitly v4.

This change was rolled back.

@alistair-singh We should not use VersionedLocation for fields in storage. There is other commentary in the PR about this.

What is stopping someone from rolling over xcm versions prelude without us knowing and breaking the lookup of Tokens?

With paritytech@5ef32c8 will just not compile.

bridges/snowbridge/primitives/core/src/lib.rs

bridges/snowbridge/primitives/core/src/outbound.rs

bridges/snowbridge/primitives/router/src/inbound/mod.rs

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs

claravanstaden

Nice work! Such a cool feature. 🌟

bridges/snowbridge/pallets/system/src/lib.rs

bridges/snowbridge/primitives/core/src/lib.rs

bridges/snowbridge/primitives/core/src/outbound.rs

bridges/snowbridge/primitives/router/src/outbound/mod.rs

...arachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs

bridges/snowbridge/pallets/system/src/lib.rs

bridges/snowbridge/primitives/core/src/lib.rs

bridges/snowbridge/primitives/core/src/outbound.rs

alistair-singh · 2024-09-01T22:59:02Z

bridges/snowbridge/pallets/system/src/benchmarking.rs

+
+		T::Token::mint_into(&caller, amount)?;
+
+		let relay_token_asset_id: Location = Location::new(1, [GlobalConsensus(Westend)]);


This looks like we accepting this in Location relative to the Ethereum address.
I think we should accept an asset relative to bridge hub as input, and then re-achoring it onto the bridge location.

Yeah, this is the Location relative to the Ethereum after reanchored on AH in

polkadot-sdk/polkadot/xcm/pallet-xcm/src/lib.rs

Line 1944 in 9368712

reanchored_assets

On BH outbound router we check the asset location registered as expected in

polkadot-sdk/bridges/snowbridge/primitives/router/src/outbound/mod.rs

Lines 386 to 390 in b19c1e1

let token_id = TokenIdOf::convert_location(&asset_id).ok_or(InvalidAsset)?;

let expected_asset_id = ConvertAssetId::convert(&token_id).ok_or(InvalidAsset)?;

ensure!(asset_id == expected_asset_id, InvalidAsset);

I prefer to register PNA with the reanchored location directly without adding reanchor logic in outbound router every time when receiving the xcm from AH.

I am suggesting doing the re-anchoring once inside the registration extrinsic.

All other XCM related functions, when taking locations as input, are relative to the current chain. See pallet-xcm for example. So its not obvious to users that this is the required way to call it.

The other thing is that Locations are not distinct:
(2, [GlobalConsensus(Westend)]) and (1, [Here]) are the same asset and if re-anchoring from bridge hub will both collapse down to the unique (1, [GlobalConsensus(Westend)]). So they get the same id.

All other XCM related functions, when taking locations as input, are relative to the current chain

Yeah, that's true. But it's a bit different here actually the asset location is reanchored in pallet-xcm relative to Ethereum in the view of AH. Then routed to BH with SovereignPaidRemoteExporter without reanchoring.

TBH I don't think the reanchor in pallet-xcm is nessessary at all for our use case. But it's another story.

So I'd prefer to make things easy for now(Permissionless register token is not even enabled yet) and improve it later in another PR.

@alistair-singh WDYT?

bridges/snowbridge/pallets/system/src/lib.rs

bridges/snowbridge/primitives/router/src/inbound/mod.rs

* Register token from polkadot * Extract AssetRegistrarMetadata * ReserveTransfer from AssetHub * Transfer DOT back to AssetHub * Fix breaking tests * Fix register token * Increase dispatch_gas to cover the actual cost for register token * Add ConvertAssetId to outbound router * Rename to SendForeignToken * Update cost * Move Command.RegisterToken to top level * Use VersionedLocation for storage * Use versioned location * TokenIdOf follow the same pattern as AgentIdOf * Rename MintToken to TransferNativeToken * Rename as SendNativeToken * More refactoring * Remove AgentExecuteCommand * Remove TokenExists check * Update cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Benchmark register_token * More checks for the events * More tests for send native token * More tests describe tokenID * More asset identifiers * Add LocationToToken & Always use VersionedLocation * Fix breaking tests * Update gas cost for registering polkadot token * Add AgentExecuteCommand back for compatibility * Split into 2 tests each covers one direction * Revert the change on AH * Switch to native token on penpal for the integration * Make fee asset as configuration parameter of the Channel * Revert fee_asset_id as channel property * Short epoch * Fix integration tests * Fix format * Cleanup * Register relay token * Use relay token as fee asset * Fix clippy * Fix missing dependency * Remove reanchored prefix from asset_id * Fix test * Fix the instruction * Fix test * Multi hop transfer * Fix tests * allow bridge hub assets * Register token from BH directly and remove force_register_token * Decrease gas estimation for PNA * Cleanup * Store Location rather than VersionedLocation * Fix test * Add more tests * Revamp reanchor logic * Improve reanchor & Fix tests * Use secondary governance channel to register PNA * Rename as asset location * Use BoundVec limit size of name&symbol * Describe location of PNA & more tests * Add test * Fix taplo * More tests * Cleanup * Format code * Batch rename token command * Remove agent_id * Rename as AssetMetadata * Add test for penpal native token --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

bridges/snowbridge/pallets/system/src/lib.rs

# Description Adding support for send polkadot native assets(PNA) to Ethereum network through snowbridge. Asset with location in view of AH Including: - Relay token `(1,Here)` - Native asset `(0,[PalletInstance(instance),GenereIndex(index)])` managed by Assets Pallet - Native asset of Parachain `(1,[Parachain(paraId)])` managed by Foreign Assets Pallet The original PR in Snowfork#128 which has been internally reviewed by Snowbridge team. # Notes - This feature depends on the companion solidity change in Snowfork/snowbridge#1155. Currently register PNA is only allowed from [sudo](https://github.com/Snowfork/polkadot-sdk/blob/46cb3528cd8cd1394af2335a6907d7ab8647717a/bridges/snowbridge/pallets/system/src/lib.rs#L621), so it's actually not enabled. Will require another runtime upgrade to make the call permissionless together with upgrading the Gateway contract. - To make things easy multi-hop transfer(i.e. sending PNA from Ethereum through AH to Destination chain) is not support ed in this PR. For this case user can switch to 2-phases transfer instead. --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

# Description Adding support for send polkadot native assets(PNA) to Ethereum network through snowbridge. Asset with location in view of AH Including: - Relay token `(1,Here)` - Native asset `(0,[PalletInstance(instance),GenereIndex(index)])` managed by Assets Pallet - Native asset of Parachain `(1,[Parachain(paraId)])` managed by Foreign Assets Pallet The original PR in #128 which has been internally reviewed by Snowbridge team. # Notes - This feature depends on the companion solidity change in Snowfork/snowbridge#1155. Currently register PNA is only allowed from [sudo](https://github.com/Snowfork/polkadot-sdk/blob/46cb3528cd8cd1394af2335a6907d7ab8647717a/bridges/snowbridge/pallets/system/src/lib.rs#L621), so it's actually not enabled. Will require another runtime upgrade to make the call permissionless together with upgrading the Gateway contract. - To make things easy multi-hop transfer(i.e. sending PNA from Ethereum through AH to Destination chain) is not support ed in this PR. For this case user can switch to 2-phases transfer instead. --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

yrong added 2 commits March 21, 2024 22:28

Register token from polkadot

6019c8d

Extract AssetRegistrarMetadata

c613fc6

yrong mentioned this pull request Mar 21, 2024

Asset from polkadot Snowfork/snowbridge#1155

Merged

yrong added 6 commits March 22, 2024 09:09

ReserveTransfer from AssetHub

9672b52

Transfer DOT back to AssetHub

c017bfe

Fix breaking tests

3dc37ea

Fix register token

1f00024

Increase dispatch_gas to cover the actual cost for register token

a20a8b7

Add ConvertAssetId to outbound router

41104d5

yrong marked this pull request as ready for review March 26, 2024 17:04

yrong added 2 commits March 27, 2024 09:55

Rename to SendForeignToken

a8b006b

Update cost

b8a75d1

yrong commented Mar 29, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs Outdated Show resolved Hide resolved

This was referenced Apr 1, 2024

Multiple fees for reserve_transfer_assets paritytech/polkadot-sdk#3918

Closed

Fee in WETH #132

Closed

Make bridge fees as params of reserve_transfer_assets paritytech/polkadot-sdk#3931

Closed

alistair-singh reviewed Apr 3, 2024

View reviewed changes

yrong added 8 commits April 5, 2024 00:22

Move Command.RegisterToken to top level

fec5a63

Use VersionedLocation for storage

a683680

Use versioned location

3621de4

TokenIdOf follow the same pattern as AgentIdOf

f7ed096

Rename MintToken to TransferNativeToken

36bb656

Rename as SendNativeToken

cf091f6

Merge branch 'snowbridge' into ron/polkadot-assets-on-ethereum

4921280

More refactoring

10c5e10

yrong requested a review from vgeddes April 9, 2024 00:39

Remove AgentExecuteCommand

587fb6e

yrong changed the base branch from snowbridge to bridge-next-gen April 9, 2024 12:07

claravanstaden reviewed Apr 9, 2024

View reviewed changes

Remove TokenExists check

f56567d

yrong added 6 commits August 28, 2024 21:25

Merge branch 'ron/short-epoch' into ron/polkadot-assets-on-ethereum

21fa444

Store Location rather than VersionedLocation

2675241

Fix test

42933da

Merge branch 'snowbridge' into ron/polkadot-assets-on-ethereum

760d697

Add more tests

a550c42

Revamp reanchor logic

736fe90

vgeddes reviewed Aug 29, 2024

View reviewed changes

yrong added 14 commits August 29, 2024 23:55

Improve reanchor & Fix tests

d1b8d16

Use secondary governance channel to register PNA

897fdad

Rename as asset location

e733321

Use BoundVec limit size of name&symbol

31c75e9

Describe location of PNA & more tests

009402e

Add test

949fb45

Fix taplo

b38b20c

More tests

0b2f782

Cleanup

62eef65

Format code

39a84b9

Batch rename token command

5ae8b0b

Remove agent_id

6ca963d

Rename as AssetMetadata

79e62fa

Add test for penpal native token

8a4f582

vgeddes approved these changes Sep 2, 2024

View reviewed changes

yrong merged commit b19c1e1 into snowbridge Sep 2, 2024
8 checks passed

yrong deleted the ron/polkadot-assets-on-ethereum branch September 2, 2024 09:00

alistair-singh reviewed Sep 2, 2024

View reviewed changes

bridges/snowbridge/pallets/system/src/lib.rs Show resolved Hide resolved

yrong mentioned this pull request Sep 3, 2024

Transfer Polkadot-native assets to Ethereum paritytech/polkadot-sdk#5546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Polkadot assets on ethereum #128

Polkadot assets on ethereum #128

yrong commented Mar 21, 2024

alistair-singh Apr 3, 2024

yrong Apr 4, 2024

alistair-singh Sep 2, 2024

vgeddes Sep 2, 2024

alistair-singh Sep 2, 2024

yrong Sep 3, 2024 •

edited

Loading

claravanstaden left a comment

alistair-singh Sep 1, 2024

yrong Sep 2, 2024 •

edited

Loading

alistair-singh Sep 2, 2024

yrong Sep 3, 2024 •

edited

Loading


		T::Token::mint_into(&caller, amount)?;

		let relay_token_asset_id: Location = Location::new(1, [GlobalConsensus(Westend)]);

	let token_id = TokenIdOf::convert_location(&asset_id).ok_or(InvalidAsset)?;

	let expected_asset_id = ConvertAssetId::convert(&token_id).ok_or(InvalidAsset)?;

	ensure!(asset_id == expected_asset_id, InvalidAsset);

Polkadot assets on ethereum #128

Polkadot assets on ethereum #128

Conversation

yrong commented Mar 21, 2024

alistair-singh Apr 3, 2024

Choose a reason for hiding this comment

yrong Apr 4, 2024

Choose a reason for hiding this comment

alistair-singh Sep 2, 2024

Choose a reason for hiding this comment

vgeddes Sep 2, 2024

Choose a reason for hiding this comment

alistair-singh Sep 2, 2024

Choose a reason for hiding this comment

yrong Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

claravanstaden left a comment

Choose a reason for hiding this comment

alistair-singh Sep 1, 2024

Choose a reason for hiding this comment

yrong Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

alistair-singh Sep 2, 2024

Choose a reason for hiding this comment

yrong Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

yrong Sep 3, 2024 •

edited

Loading

yrong Sep 2, 2024 •

edited

Loading

yrong Sep 3, 2024 •

edited

Loading