This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Update Polkadot-SDK #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et-xcm-fully-support-reserve-transfers
… instead of pallet_xcm
…et-xcm-fully-support-reserve-transfers
…et-xcm-fully-support-reserve-transfers
…et-xcm-fully-support-reserve-transfers
claravanstaden
changed the base branch from
pallet-xcm-fully-support-reserve-transfers
to
snowbridge
…-from-adrian # Conflicts: # Cargo.lock # cumulus/parachains/integration-tests/emulated/bridges/bridge-hub-rococo/Cargo.toml # cumulus/parachains/integration-tests/emulated/common/src/lib.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs
claravanstaden
changed the base branch from
snowbridge
to
pallet-xcm-fully-support-reserve-transfers
Alistair/send fees with xcm
Companion for snowbridge #1003
added 5 commits
November 13, 2023 18:07
# Conflicts: # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs # polkadot/xcm/pallet-xcm/src/benchmarking.rs # polkadot/xcm/pallet-xcm/src/lib.rs
# Conflicts: # Cargo.lock # cumulus/parachains/integration-tests/emulated/bridges/bridge-hub-rococo/Cargo.toml # cumulus/parachains/integration-tests/emulated/bridges/bridge-hub-rococo/src/tests/snowbridge.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs
claravanstaden
changed the base branch from
pallet-xcm-fully-support-reserve-transfers
to
master
vgeddes
reviewed
Nov 15, 2023
There was a problem hiding this comment.
I think we are going to get pushback on making these changes to the template parachain, especially when this parachain isn't really meant for testing.
Instead, we should use the PenPal test parachain. See the description here:
Apparently we can configure it with arbitrary parachain IDs
| /// Send an XCM message as parachain sovereign. | ||
| #[pallet::call_index(2)] | ||
| #[pallet::weight(Weight::from_parts(100_000_000, 0))] | ||
| pub fn send_xcm( |
There was a problem hiding this comment.
We should move this to the PenPal test parachain.
Can create a pallet for it somewhere under cumulus/parachains/runtimes/testing/penpal/
| /// Polkadot uses 12 decimals, Kusama and Rococo 10 decimals. | ||
| pub const BridgeHubEthereumBaseFeeInDOT: u128 = 27_508_725_000; | ||
| pub const BridgeHubEthereumBaseFeeInKSM: u128 = 2_750_872_500_000; | ||
| pub const BridgeHubEthereumBaseFeeInRocs: u128 = 2_750_872_500_000; |
There was a problem hiding this comment.
Suggested change
| pub const BridgeHubEthereumBaseFeeInRocs: u128 = 2_750_872_500_000; | |
| pub const BridgeHubEthereumBaseFeeInROC: u128 = 2_750_872_500_000; |
| @@ -20,6 +20,7 @@ pub mod kusama; | |||
| pub mod message_queue; | |||
| pub mod polkadot; | |||
| pub mod rococo; | |||
| pub mod snowbridge_config; | |||
There was a problem hiding this comment.
We can't really put these configs in this crate - Its too specific to Snowbridge.
Can I suggest that we rather add this to each AssetHub runtime lib.rs:
parameter_types! {
BridgeHubEthereumBaseFee = ...
}Then I'm sure after submitting the PR we'll get more feedback about an appropriate place to put this config.
|
Closing in favour of #28. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update after fetching changes from https://github.com/paritytech/polkadot-sdk/pull/1672/files.
Snowbridge companion: Snowfork/snowbridge#1002